Fix glyph assembly data for axisheight5000-verticalarrow14000.woff #22084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make full advance of the "bot" match the glyph height (19em). instead of the incorrect 1em value. * Force min overlap to be 0 and max part overlap to be 1em, so that GlyphAssembly is valid per [1] and the engine has flexibility to adjust the overlap in order to match the target size. [1] https://mathml-refresh.github.io/mathml-core/#the-glyphassembly-table "For each GlyphPartRecord in GlyphAssembly.partRecords, the values of GlyphPartRecord.startConnectorLength and GlyphPartRecord.endConnectorLength must be at least omin. Otherwise, it is not possible to satisfy the condition of MathVariant.minConnectorOverlap."
fred-wang
requested review from
rwlbuis
and removed request for
fantasai and
kojiishi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of the incorrect 1em value.
that GlyphAssembly is valid per [1] and the engine has
flexibility to adjust the overlap in order to match the target
size.
[1] https://mathml-refresh.github.io/mathml-core/#the-glyphassembly-table
"For each GlyphPartRecord in GlyphAssembly.partRecords, the values of GlyphPartRecord.startConnectorLength and GlyphPartRecord.endConnectorLength must be at least omin. Otherwise, it is not possible to satisfy the condition of MathVariant.minConnectorOverlap."