Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky Composite Order test #22202

Merged
merged 1 commit into from Mar 12, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Mar 12, 2020

This patch fixes the flakiness in getting running-animation order by
making sure the animation is running before we make a measurement.

This test passed all 500 repeated run.

Bug: 1060216
Change-Id: I8b271e1e0d31dac0203aa3a7bb3359f7f1d1eec6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099474
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Hao Sheng <haozhes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749528}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This patch fixes the flakiness in getting running-animation order by
making sure the animation is running before we make a measurement.

This test passed all 500 repeated run.

Bug: 1060216
Change-Id: I8b271e1e0d31dac0203aa3a7bb3359f7f1d1eec6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099474
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Hao Sheng <haozhes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749528}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants