[Trusted Types] Fix script handling for XML Documents. #22218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 12, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2100928
branch
3 times, most recently
from
f88affd
to
d21af88
Compare
XMLDocumentParser::UpdateLeafTextNode calls CharacterData::appendData (rather than CharacterData::ParserAppendData), which means this change is incorrectly attributed to a user script. Additionally, CharacterData::DidModifyData now passes UpdateSource correctly to the ChildrenChange event. Bug: 1060949 Change-Id: Ida8c93bc68f66da45221a8490b84b669898b084f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100928 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#750113}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2100928
branch
from
d21af88
to
15fbdc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XMLDocumentParser::UpdateLeafTextNode calls CharacterData::appendData (rather
than CharacterData::ParserAppendData), which means this change is incorrectly
attributed to a user script. Additionally, CharacterData::DidModifyData now
passes UpdateSource correctly to the ChildrenChange event.
Bug: 1060949
Change-Id: Ida8c93bc68f66da45221a8490b84b669898b084f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100928
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750113}