(Declarative Shadow DOM) Use shadowroot attribute value from open tag #22303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 17, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2106737
branch
3 times, most recently
from
2e712e4
to
eda6223
Compare
Prior to this CL, the "shadowroot" attribute from the <template> DOM node would be read back upon encountering the closing tag, to determine whether to attach a shadow root. To better align with the spec, with this CL, the "shadowroot" token attribute from the opening <template shadowroot> tag is used instead. This CL also starts to add testing of declarative shadow DOM. Bug: 1042130 Change-Id: I0f52a3baa4c1f11d4cce7d1001ec80a31f139e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106737 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#752169}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2106737
branch
from
eda6223
to
9acff8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this CL, the "shadowroot" attribute from the <template>
DOM node would be read back upon encountering the closing tag,
to determine whether to attach a shadow root. To better align with
the spec, with this CL, the "shadowroot" token attribute from the
opening <template shadowroot> tag is used instead.
This CL also starts to add testing of declarative shadow DOM.
Bug: 1042130
Change-Id: I0f52a3baa4c1f11d4cce7d1001ec80a31f139e48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106737
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752169}