Implement basic support for 'revert' #22615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 1, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2130268
branch
from
17dcf61
to
e78c3ca
Compare
CascadeMap now holds the cascaded declarations for the user-agent, user, and author origins separately. The 'revert' keyword is resolved to the cascaded value for the target origin before being applied to ComputedStyle. (This can happen recursively up to the kUserAgent origin. Note that 'revert' will not yet work to/from surrogates (css-logical properties), nor in @Keyframes. Bug: 579788 Change-Id: I98b40d596867129e486035f9cd9f20e7b7cbe08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130268 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#756268}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2130268
branch
from
e78c3ca
to
e7cbd66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CascadeMap now holds the cascaded declarations for the user-agent, user,
and author origins separately. The 'revert' keyword is resolved to
the cascaded value for the target origin before being applied to
ComputedStyle. (This can happen recursively up to the kUserAgent origin.
Note that 'revert' will not yet work to/from surrogates (css-logical
properties), nor in @Keyframes.
Bug: 579788
Change-Id: I98b40d596867129e486035f9cd9f20e7b7cbe08e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130268
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756268}