[Gecko Bug 1625755] Make HTMLEditor::DoInsertHTMLWithContext() check whether inserted content stays at expected point before modifying next insertion point
#22668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontent stays at expected point before modifying next insertion point I'm still not sure how the crash occurs especially on Thunderbird. However, it could be possible if `pointToInsert` is modified with an orphan node (i.e., when `pointToInsert.GetContainer()` returns `nullptr`). Therefore, this patch makes it check whether the inserted node stays at expected position or not, and if it's not, make it keep inserting next content nodes to previous position because it must look like odd that inserting to different position. Differential Revision: https://phabricator.services.mozilla.com/D69154 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1625755 gecko-commit: 2839bb5efce7296af4e4ab2ac0c316c1e1c3563a gecko-integration-branch: autoland gecko-reviewers: m_kato
wpt-pr-bot
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still not sure how the crash occurs especially on Thunderbird. However,
it could be possible if
pointToInsertis modified with an orphan node (i.e.,when
pointToInsert.GetContainer()returnsnullptr). Therefore, this patchmakes it check whether the inserted node stays at expected position or not,
and if it's not, make it keep inserting next content nodes to previous position
because it must look like odd that inserting to different position.
Differential Revision: https://phabricator.services.mozilla.com/D69154
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1625755
gecko-commit: 2839bb5efce7296af4e4ab2ac0c316c1e1c3563a
gecko-integration-branch: autoland
gecko-reviewers: m_kato