[css-filters] Migrate direct-image-dynamic-filter.html test to WPT #22695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 3, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2134258
branch
from
4b36e99
to
814b8e1
Compare
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. In addition, this test uses <html class="reftest-wait"> as described in [1] to replace the code that was depending on testRunner in order to make sure that the screenshot is taking at the right time. Last, the original test relied on a green-256x256.jpg image that is exactly equivalent to the PNG version already in WPT, so this test has been migrated to use that one instead. [1] https://web-platform-tests.org/writing-tests/reftests.html?highlight=reftests#controlling-when-comparison-occurs Bug: 1063749 Change-Id: Idcd76fcf3b1e82fe14be602c120d8c105f5c658a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134258 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#756456}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2134258
branch
from
814b8e1
to
151377c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate this test out of third_party/blink/web_tests/css3/filters
and into the WPT-specific directory, adding links to the relevant
specs and a test assertion describing its purpose.
In addition, this test uses <html class="reftest-wait"> as described
in [1] to replace the code that was depending on testRunner in order
to make sure that the screenshot is taking at the right time.
Last, the original test relied on a green-256x256.jpg image that is
exactly equivalent to the PNG version already in WPT, so this test
has been migrated to use that one instead.
[1] https://web-platform-tests.org/writing-tests/reftests.html?highlight=reftests#controlling-when-comparison-occurs
Bug: 1063749
Change-Id: Idcd76fcf3b1e82fe14be602c120d8c105f5c658a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134258
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#756456}