[LayoutNG] Change NGBlockLayoutAlgorithm::FinishInflow DCHECK. #22736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 6, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2137377
branch
from
d6ca545
to
a1e1508
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2137377
branch
2 times, most recently
from
81aa959
to
0bad5db
Compare
If we had an empty linebox with a float inside it (and the float was shifted due to other floats) it was possible for that linebox to fail the DCHECK in: ng_block_layout_algorithm.cc:1584 DCHECK(!normal_child_had_clearance || !is_self_collapsing); Both of these conditions were true. This patch changes the normal_child_had_clearance variable to only be true if it was a *block* child (not inline), pushed by floats. Bug: 1064987 Change-Id: Ie326437a637cc57d1b17f91ac5e49847fd13c983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137377 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#768944}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2137377
branch
from
0bad5db
to
663ea5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we had an empty linebox with a float inside it (and the float was
shifted due to other floats) it was possible for that linebox to fail
the DCHECK in:
ng_block_layout_algorithm.cc:1584
DCHECK(!normal_child_had_clearance || !is_self_collapsing);
Both of these conditions were true.
This patch changes the normal_child_had_clearance variable to only be
true if it was a block child (not inline), pushed by floats.
Bug: 1064987
Change-Id: Ie326437a637cc57d1b17f91ac5e49847fd13c983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137377
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768944}