Rework WPT: /fetch/stale-while-revalidate/stale-script.html #23069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 17, 2020
Mainly for improving my own understanding. I would like to make some tests about CSP vs stale-while-revalidate for issue 1070117 This patch: 1) Use Promise(s) instead of callback(s). This unwrap the logic flow. 2) Make "last_modified_count" to count the number of new version being served. Previously, it was a bit confusing to me. 3) Extend the test to check the "revalidated" version is served on the 3rd load. 4) Small misc refactorings. Bug: 1070117 Change-Id: Ifba23d78e539eb50262244f59e7c16e1b9ca56ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154786 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#760550}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2154786
branch
from
d5315e6
to
51f21ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly for improving my own understanding. I would like to make some
tests about CSP vs stale-while-revalidate for issue 1070117
This patch:
Use Promise(s) instead of callback(s). This unwrap the logic flow.
Make "last_modified_count" to count the number of new version being
served. Previously, it was a bit confusing to me.
Extend the test to check the "revalidated" version is served on the
3rd load.
Small misc refactorings.
Bug: 1070117
Change-Id: Ifba23d78e539eb50262244f59e7c16e1b9ca56ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154786
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760550}