Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventTiming] Test more event types #23511

Merged
merged 1 commit into from May 14, 2020
Merged

[EventTiming] Test more event types #23511

merged 1 commit into from May 14, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 11, 2020 •
edited

Bug: 543598
Change-Id: I8bc74c88a3125bb9c614416e39054668e3466d91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191238
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768441}

wpt-pr-bot
wpt-pr-bot approved these changes May 11, 2020
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@npm1 @chromium-wpt-export-bot
[EventTiming] Test more event types
1c4c718 
Bug: 543598
Change-Id: I8bc74c88a3125bb9c614416e39054668e3466d91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191238
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768441}
@LukeZielinski
Copy link
Contributor

One of the tests appears flaky on Chrome dev:

Unstable results

Test Subtest Results Messages
/event-timing/dblclick.html Event Timing dblclick. FAIL: 5/10, PASS: 5/10 assert_greater_than: The entry's processingStart should be greater than startTime. expected a number greater than 560.6299999999464 but got 560.6299999999464;assert_greater_than: The entry's processingStart should be greater than startTime. expected a number greater than 565.0999999998021 but got 565.0999999998021;assert_greater_than: The entry's processingStart should be greater than startTime. expected a number greater than 575.4649999998946 but got 575.4649999998946;assert_greater_than: The entry's processingStart should be greater than startTime. expected a number greater than 564.909999999827 but got 564.909999999827;assert_greater_than: The entry's processingStart should be greater than startTime. expected a number greater than 577.239999999847 but got 577.239999999847

@LukeZielinski
Copy link
Contributor

Filed crbug.com/1082739. @Hexcles could you please admin merge?

@Hexcles Hexcles merged commit 7758533 into master May 14, 2020
@Hexcles Hexcles deleted the chromium-export-cl-2191238 branch May 14, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
chromium-export event-timing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chromium-wpt-export-bot @LukeZielinski @wpt-pr-bot @Hexcles @npm1