[ua-ch] Ensure UADataValues' entries are initially undefined #23548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 12, 2020
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2196487
branch
3 times, most recently
from
9ac6d44
to
f09f1e9
Compare
The UA-CH IDL [1] defines UADataValues as initially undefined. That makes it so that if someone doesn't explicitly ask for a value, the UADataValue object will not contain it. This CL aligns the implementation with the spec. [1] https://wicg.github.io/ua-client-hints/#interface Bug: 1081837 Change-Id: I4c4abf19537796b2c192c70be0860b004892f734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196487 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Maksim Orlovich <morlovich@chromium.org> Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#768137}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2196487
branch
from
f09f1e9
to
84d698c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UA-CH IDL [1] defines UADataValues as initially undefined.
That makes it so that if someone doesn't explicitly ask for a value,
the UADataValue object will not contain it.
This CL aligns the implementation with the spec.
[1] https://wicg.github.io/ua-client-hints/#interface
Bug: 1081837
Change-Id: I4c4abf19537796b2c192c70be0860b004892f734
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196487
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#768137}