[css-grid] Consider 'auto' height items for grid area estimation #23772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 26, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2215054
branch
from
bfc3b5e
to
9296fe5
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2215054
branch
from
9296fe5
to
798d01b
Compare
We perform a pre-layout, based on a estimation of the grid area, of the grid items in two different situations: orthogonal and baseline aligned items. In the case of baseline aligned items, we were doing this pre-layout only in the case of items with relative inline and block sizes. However, items with 'auto' block-size also depend on this estimated grid area size to properly compute the baseline offset. It was discarded in the past due to performance concerns, since the 'auto' height is a very common case. However, this codepath is only executed for baseline aligned items. Since we already applied several optimization to the baseline alignment logic, I think we can try this approach to solve the bug and evaluate potential perf regressions when they appear. Bug: 1086132 Change-Id: I73c39e6c3ad6cd74aa50fe33106e25cd63b7625f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215054 Reviewed-by: Manuel Rego <rego@igalia.com> Reviewed-by: Oriol Brufau <obrufau@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#774139}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2215054
branch
from
798d01b
to
301887a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We perform a pre-layout, based on a estimation of the grid area, of the
grid items in two different situations: orthogonal and baseline aligned
items.
In the case of baseline aligned items, we were doing this pre-layout
only in the case of items with relative inline and block sizes. However,
items with 'auto' block-size also depend on this estimated grid area
size to properly compute the baseline offset.
It was discarded in the past due to performance concerns, since the
'auto' height is a very common case. However, this codepath is only
executed for baseline aligned items. Since we already applied several
optimization to the baseline alignment logic, I think we can try this
approach to solve the bug and evaluate potential perf regressions when
they appear.
Bug: 1086132
Change-Id: I73c39e6c3ad6cd74aa50fe33106e25cd63b7625f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215054
Reviewed-by: Manuel Rego <rego@igalia.com>
Reviewed-by: Oriol Brufau <obrufau@igalia.com>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#774139}