Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventTiming] Allow spurious inputs when looseCount is true #23925

Merged
merged 2 commits into from Jun 4, 2020
Merged

[EventTiming] Allow spurious inputs when looseCount is true #23925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f8150f
[EventTiming] Allow spurious inputs when looseCount is true
npm1 Jun 3, 2020
7825646
Give two event-timing tests long timeout
Hexcles Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions event-timing/mousedown.html
View file
Open in desktop
@@ -1,6 +1,7 @@
<!DOCTYPE html>
<html>
<meta charset=utf-8 />
<meta name="timeout" content="long">
<title>Event Timing mousedown.</title>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
Expand Down
1 change: 1 addition & 0 deletions event-timing/pointerdown.html
View file
Open in desktop
@@ -1,6 +1,7 @@
<!DOCTYPE html>
<html>
<meta charset=utf-8 />
<meta name="timeout" content="long">
<title>Event Timing pointerdown.</title>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
Expand Down
14 changes: 8 additions & 6 deletions event-timing/resources/event-timing-test-utils.js
View file
Open in desktop
Expand Up @@ -204,21 +204,23 @@ function testCounts(t, resolve, looseCount, eventType, expectedCount) {

// Tests the given |eventType| by creating events whose target are the element with id
// 'target'. The test assumes that such element already exists. |looseCount| is set for
// eventTypes for which events would occur for other elements besides the target, so the
// counts will be larger.
// eventTypes for which events would occur for other interactions other than the ones being
// specified for the target, so the counts could be larger.
async function testEventType(t, eventType, looseCount=false) {
assert_implements(window.EventCounts, "Event Counts isn't supported");
assert_equals(performance.eventCounts.get(eventType), 0);
const target = document.getElementById('target');
if (requiresListener(eventType)) {
target.addEventListener(eventType, () =>{});
}
assert_equals(performance.eventCounts.get(eventType), 0, 'No events yet.');
const initialCount = performance.eventCounts.get(eventType);
if (!looseCount) {
assert_equals(initialCount, 0, 'No events yet.');
}
// Trigger two 'fast' events of the type.
await applyAction(eventType, target);
await applyAction(eventType, target);
await new Promise(t.step_func(resolve => {
testCounts(t, resolve, looseCount, eventType, 2);
testCounts(t, resolve, looseCount, eventType, initialCount + 2);
}));
// The durationThreshold used by the observer. A slow events needs to be slower than that.
const durationThreshold = 16;
Expand Down Expand Up @@ -254,7 +256,7 @@ async function testEventType(t, eventType, looseCount=false) {
notCancelable(eventType));
// Shouldn't need async testing here since we already got the observer entry, but might as
// well reuse the method.
testCounts(t, resolve, looseCount, eventType, 3);
testCounts(t, resolve, looseCount, eventType, initialCount + 3);
})).observe({type: 'event', durationThreshold: durationThreshold});
});
// Cause a slow event.
Expand Down