De-flake cross-domain-iframe.sub.html #24069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 9, 2020
If this doesn't deflake the test, then I suspect that there is an issue on some bots with the cross-origin domain name being resolved. On my machine, the origin of the iframe was www1.web-platform.test:8001, and if the machine doesn't have the custom wpt domains configured, then the test will produce a white screen just like the flaky failures. Bug: 1091270 Change-Id: I4db90275632166b01a53fc6a7fa54c006c4c14d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236740 Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#776976}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2236740
branch
from
76951b1
to
7f9a915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this doesn't deflake the test, then I suspect that there is an issue
on some bots with the cross-origin domain name being resolved. On my
machine, the origin of the iframe was www1.web-platform.test:8001, and
if the machine doesn't have the custom wpt domains configured, then the
test will produce a white screen just like the flaky failures.
Bug: 1091270
Change-Id: I4db90275632166b01a53fc6a7fa54c006c4c14d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236740
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776976}