Add additional Web Platform Tests for the Split Cache #24075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This expands the existing web platform tests to ensure that same-origin frames do not share a cache if their top-level origins are different. The additional tests create a popup with an iframe, where the iframe is same-origin to the opener. When the popup's mainframe is also same-origin to the opener, we expect the cache to be shared. Otherwise, it should not be. As with the existing tests, two virtual test suites test the cases of a split and non-split cache. The default test is disabled as its result depends on whether the split cache is enabled. Bug: 1064765 Change-Id: If301e03e0a07a681f960a0972c02fd452b19d798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238306 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#776663}
wpt-pr-bot
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the existing web platform tests to ensure that same-origin
frames do not share a cache if their top-level origins are different.
The additional tests create a popup with an iframe, where the iframe is
same-origin to the opener. When the popup's mainframe is also
same-origin to the opener, we expect the cache to be shared. Otherwise,
it should not be.
As with the existing tests, two virtual test suites test the cases of a
split and non-split cache. The default test is disabled as its result
depends on whether the split cache is enabled.
Bug: 1064765
Change-Id: If301e03e0a07a681f960a0972c02fd452b19d798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238306
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776663}