Add test that inactivate/activate a transceiver and ensure corresponding track stays live #24112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing track stays live
wpt-pr-bot
requested review from
agouaillard,
alvestrand,
guidou,
henbos,
jan-ivar,
rwaldron and
snuggs
jan-ivar
approved these changes
Jun 11, 2020
|
why is/was it necessary to remove the a=ssrc lines? |
|
also the test uses the same peerconnection over multiple tests which is not a good pattern. In chrome that causes failure of the subsequent tests after the first test fails due to the dependency on GUM (which needs https in chrome and the test is not flagged as such) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the direction, we remove the ssrcs when setting direction to inactive, which triggers the remote track to get ended on Chrome and Safari. Firefox keeps the track as live.