WebXR - fix bugs in WPTs and clarify meaning of time deltas #24119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 11, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2240293
branch
from
6bb70db
to
f3cddb6
Compare
Changes: - specify the meaning of time_delta sent over via XRFrameData - fix bug in rAF test - the test was not reaching the second stage and had incorrect assumptions - add correct handling of the time_delta in XRFrameProvider - first received XRFrameData is used to "synchronize the watches" between blink and device - webxr-test.js no longer uses internals module Bug: 1093398 Change-Id: I9398e88a9a7d445c461fdcbacbfd0e3e07df0620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240293 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#777645}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2240293
branch
from
f3cddb6
to
afc47c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
had incorrect assumptions
received XRFrameData is used to "synchronize the watches" between blink
and device
Bug: 1093398
Change-Id: I9398e88a9a7d445c461fdcbacbfd0e3e07df0620
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240293
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777645}