Clipboard API: Implement the HTML clipboard reader and writer. #24175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 16, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2243532
branch
6 times, most recently
from
701cec4
to
59b955f
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2243532
branch
from
59b955f
to
3dea722
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2243532
branch
7 times, most recently
from
66bd130
to
3a38fe9
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2243532
branch
4 times, most recently
from
ee4650d
to
75959a1
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2243532
branch
from
75959a1
to
6267fd5
Compare
This CL adds two subclasses: ClipboardHTMLReader and ClipboardHTMLWriter. When HTML is read and written it is "sanitized" which means that all script objects are removed from the html. They are both entirely synchronous because it is impossible to use HTML DOM nodes off of the main thread. Design Doc: https://docs.google.com/document/d/1tzjfckWUKAAxEbKcUjg21uz7LFDMQ7ZDzfTTj3Lp93Y/edit Bug: 931839 Change-Id: I29b26f1c721102005bcbb5911549a9546aed3006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243532 Commit-Queue: Dylan Sleeper <dsleeps@google.com> Reviewed-by: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787862}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2243532
branch
from
6267fd5
to
d9a1897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds two subclasses: ClipboardHTMLReader and
ClipboardHTMLWriter. When HTML is read and written it is "sanitized"
which means that all script objects are removed from the html. They
are both entirely synchronous because it is impossible to use HTML
DOM nodes off of the main thread.
Design Doc: https://docs.google.com/document/d/1tzjfckWUKAAxEbKcUjg21uz7LFDMQ7ZDzfTTj3Lp93Y/edit
Bug: 931839
Change-Id: I29b26f1c721102005bcbb5911549a9546aed3006
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243532
Commit-Queue: Dylan Sleeper <dsleeps@google.com>
Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787862}