[FragmentItem] Fix hit-testing floats in legacy root #24231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 18, 2020
This patch fixes hit-testing floating objects in a legacy root. With |NGPaintFragment|, floats are in children, and that regular traversal can cover this case. With |FragmentItem|, floats are either in |NGFragmentItems| if it has an inline formatting context, or in children otherwise. This difference requires additional branch to the legacy fallback when hit-testing floating objects. Bug: 1096259 Change-Id: I8565eb663781318233c21482270804cf254e0aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249249 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#779715}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2249249
branch
from
b37ddc1
to
4aec3b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes hit-testing floating objects in a legacy
root.
With |NGPaintFragment|, floats are in children, and that
regular traversal can cover this case.
With |FragmentItem|, floats are either in |NGFragmentItems|
if it has an inline formatting context, or in children
otherwise. This difference requires additional branch to the
legacy fallback when hit-testing floating objects.
Bug: 1096259
Change-Id: I8565eb663781318233c21482270804cf254e0aec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249249
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779715}