Implement createConicGradient for the new canvas 2d API #24299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 22, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2252464
branch
2 times, most recently
from
4d66505
to
88303cb
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2252464
branch
9 times, most recently
from
df96d13
to
0f2d473
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2252464
branch
from
0f2d473
to
17fb47b
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2252464
branch
from
17fb47b
to
59252af
Compare
Currently hidden behind the --new-canvas-2d-api flag. https://github.com/fserb/canvas2D/blob/master/spec/conic-gradient.md whatwg/html#5431 Bug: 1097034 Change-Id: I2267539087546b29f0fd04ecef7158e7a61bb97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252464 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Yi Xu <yiyix@chromium.org> Reviewed-by: Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#794376}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2252464
branch
from
59252af
to
0d96f88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently hidden behind the --new-canvas-2d-api flag.
https://github.com/fserb/canvas2D/blob/master/spec/conic-gradient.md
whatwg/html#5431
Bug: 1097034
Change-Id: I2267539087546b29f0fd04ecef7158e7a61bb97f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252464
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794376}