[FragmentItem] Fix DirtyLinesFromNeedsLayout #24444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 5, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2281781
branch
2 times, most recently
from
56ea183
to
d173d56
Compare
This patch fixes a case where |DirtyLinesFromNeedsLayout| fails to mark items dirty for reusing cached lines. When searching for |LayoutObject| needing layout, checking |NormalChildNeedsLayout| and |PosChildNeedsLayout| were not enough. In some specific cases, only |NeedsSimplifiedNormalFlowLayout| was set for the parent inline box. This patch changes the condition to check descendants to |NeedsLayout|. Bug: 1101883 Change-Id: Ia73ace058c9ea1ebaaffdaff793b56d68099cd5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281781 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#785287}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2281781
branch
from
d173d56
to
6388d80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a case where |DirtyLinesFromNeedsLayout|
fails to mark items dirty for reusing cached lines.
When searching for |LayoutObject| needing layout, checking
|NormalChildNeedsLayout| and |PosChildNeedsLayout| were not
enough. In some specific cases, only
|NeedsSimplifiedNormalFlowLayout| was set for the parent
inline box.
This patch changes the condition to check descendants to
|NeedsLayout|.
Bug: 1101883
Change-Id: Ia73ace058c9ea1ebaaffdaff793b56d68099cd5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281781
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785287}