[FragmentItem] Limit reusing cached lines only when top-level child is clean #24453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 6, 2020
…s clean This patch simplifies |DirtyLinesFromNeedsLayout| to check |NeedsLayout| of top-level children only. The previous code tried to reuse more lines, e.g.: <div><span>many lines of text</span></div> Most lines are reusable when appending to the end of "text". But supporting this case complicates the logic, especially when culled inline is involved. The new logic can't reuse lines in the above case, but still can reuse liens if the `<span>` does not exist, and should cover most common cases. Bug: 1102083 Change-Id: I4f76e154b834c8c00e5ce04ab251c4f1fcdabab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282821 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#785345}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2282821
branch
from
97cd09a
to
9d86eae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simplifies |DirtyLinesFromNeedsLayout| to check
|NeedsLayout| of top-level children only.
The previous code tried to reuse more lines, e.g.:
<div><span>many lines of text</span></div>
Most lines are reusable when appending to the end of "text".
But supporting this case complicates the logic, especially
when culled inline is involved.
The new logic can't reuse lines in the above case, but still
can reuse liens if the
\<span>does not exist, and shouldcover most common cases.
Bug: 1102083
Change-Id: I4f76e154b834c8c00e5ce04ab251c4f1fcdabab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282821
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785345}