Portals: Support default click-to-activate. #24458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 6, 2020
This adds a default behavior whereby clicking (or equivalent) will cause the portal to immediately activate, unless the click or DOMActivate event has preventDefault called by a listener. This is guarded by a new runtime enabled feature so that this does not affect the behavior in the current origin trial. Bug: 1102081 Change-Id: I6a6c2409b0123f95d5068c54a423ac2f29e3e968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281308 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#785812}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2281308
branch
from
7f02842
to
cd291c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a default behavior whereby clicking (or equivalent) will cause
the portal to immediately activate, unless the click or DOMActivate
event has preventDefault called by a listener.
This is guarded by a new runtime enabled feature so that this does not
affect the behavior in the current origin trial.
Bug: 1102081
Change-Id: I6a6c2409b0123f95d5068c54a423ac2f29e3e968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281308
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785812}