[Gecko Bug 1650189] Fix an off-by-one in the transition property iterator. #24462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By the time we get to iterate over the longhands of a shorthand, we've already advanced the range iterator, so we look at the next duration and such, which causes this bug. I'm seriously baffled that no existing test caught this when it landed, neither in our internal test suite nor wpt... :/ Differential Revision: https://phabricator.services.mozilla.com/D82396 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1650189 gecko-commit: 7a98d6188d72664bfcf4bf9bb160ab02f5360fd4 gecko-integration-branch: autoland gecko-reviewers: mrobinson
wpt-pr-bot
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the time we get to iterate over the longhands of a shorthand, we've
already advanced the range iterator, so we look at the next duration and
such, which causes this bug.
I'm seriously baffled that no existing test caught this when it
landed, neither in our internal test suite nor wpt... :/
Differential Revision: https://phabricator.services.mozilla.com/D82396
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1650189
gecko-commit: 7a98d6188d72664bfcf4bf9bb160ab02f5360fd4
gecko-integration-branch: autoland
gecko-reviewers: mrobinson