Split mpadded-002.html first paragraph #24603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred-wang
reviewed
Jul 15, 2020
| </math> | ||
| </p> | ||
| <p> | ||
| <span id="baseline" style="display: inline-block; width: 30px; height: 5px; background: blue"></span> |
There was a problem hiding this comment.
it seems wrong to have two elements with "baseline" id, shouldn't the JS part be updated too?
There was a problem hiding this comment.
Right, good catch! Fixed.
Due to lack of line-breaking, on narrow pages the first math element will be positioned below the baseline reference. A lot of test frameworks use narrow widths for testing and calculations will fail, therefore split the first math element in half, giving a higher chance for the test framework to pass this test.
fred-wang
approved these changes
Jul 15, 2020
fred-wang
reviewed
Jul 15, 2020
| @@ -59,7 +59,7 @@ | |||
| for (var i = 0; i <= 2; i++) { | |||
| var mpadded = getBox("mpadded" + i); | |||
| assert_approx_equals(mpadded.width, 25*(1+i%3), epsilon, "width" + i); | |||
| assert_approx_equals(getBox("baseline").bottom - mpadded.top, 25*(1+(i+1)%3), epsilon, "height" + i); | |||
| assert_approx_equals(getBox("baseline2").bottom - mpadded.top, 25*(1+(i+1)%3), epsilon, "height" + i); | |||
| assert_approx_equals(mpadded.bottom - getBox("baseline").bottom, 25*(1+(i+2)%3), epsilon, "depth" + i); | |||
There was a problem hiding this comment.
mmh this one is still baseline? (I didn't read the test again, but please check carefully)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to lack of line-breaking, on narrow pages the first math
element will be positioned below the baseline reference. A lot
of test frameworks use narrow widths for testing and calculations
will fail, therefore split the first math element in half, giving
a higher chance for the test framework to pass this test.