Fix test timeouts for Analyser tests #24737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 24, 2020
These analyser tests use a ScriptProcessorNode with 0 outputs. That's not actually well-defined in the spec. so create the node with one output. And also connect the node to the destination so that Chrome will process it. (Yes, that's a bug in chrome for a deprecated ScriptProcessorNode.) Update TestExpectations too. Bug: 626703 Change-Id: I5f21e6b96c55ff66f76e43b3c7dbc7b2c2635656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316791 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#794221}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2316791
branch
from
85f549c
to
a813be4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These analyser tests use a ScriptProcessorNode with 0 outputs. That's
not actually well-defined in the spec. so create the node with one
output. And also connect the node to the destination so that Chrome
will process it. (Yes, that's a bug in chrome for a deprecated
ScriptProcessorNode.)
Update TestExpectations too.
Bug: 626703
Change-Id: I5f21e6b96c55ff66f76e43b3c7dbc7b2c2635656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316791
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794221}