New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blink][wpt] Add more module evaluation order tests #24948
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2346251
branch
6 times, most recently
from
August 13, 2020 07:38
3011b67
to
cb0d952
Compare
Add tests for upcoming microtask checkpoint fixes and top-level-await for modules. The added test cover in more detail the following items: - onload events - onerror events - queueMicrotask drive-by-fix: Check for onunhandledrejection Bug: 1022182, 1096455, 1114034, v8:9344 Change-Id: Ieaa7691bf44e2758ed873ca53bcc6852812dd723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346251 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#798126}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2346251
branch
from
August 14, 2020 17:27
cb0d952
to
f4b6e40
Compare
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Aug 21, 2020
Classic script versions of https://chromium-review.googlesource.com/c/chromium/src/+/2346251 #24948 Bug: 1114028 Change-Id: I44353438ec9356a6a55a4ed3bb22cf80b9ab554a
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Sep 2, 2020
Classic script versions of https://chromium-review.googlesource.com/c/chromium/src/+/2346251 #24948 Bug: 1114028 Change-Id: I44353438ec9356a6a55a4ed3bb22cf80b9ab554a
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Sep 7, 2020
Classic script versions of https://chromium-review.googlesource.com/c/chromium/src/+/2346251 #24948 Bug: 1114028 Change-Id: I44353438ec9356a6a55a4ed3bb22cf80b9ab554a
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Sep 15, 2020
…aredWorkers Classic script and SharedWorker versions of https://chromium-review.googlesource.com/c/chromium/src/+/2346251 #24948 Bug: 1114028, 1128214 Change-Id: I44353438ec9356a6a55a4ed3bb22cf80b9ab554a
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Sep 15, 2020
…aredWorkers Classic script and SharedWorker versions of https://chromium-review.googlesource.com/c/chromium/src/+/2346251 #24948 Bug: 1114028, 1128214 Change-Id: I44353438ec9356a6a55a4ed3bb22cf80b9ab554a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369075 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#806893}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Sep 15, 2020
…aredWorkers Classic script and SharedWorker versions of https://chromium-review.googlesource.com/c/chromium/src/+/2346251 #24948 Bug: 1114028, 1128214 Change-Id: I44353438ec9356a6a55a4ed3bb22cf80b9ab554a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369075 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#806893}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 23, 2020
…ts for classic scripts and SharedWorkers, a=testonly Automatic update from web-platform-tests [WPT] Add microtask-related ordering tests for classic scripts and SharedWorkers Classic script and SharedWorker versions of https://chromium-review.googlesource.com/c/chromium/src/+/2346251 web-platform-tests/wpt#24948 Bug: 1114028, 1128214 Change-Id: I44353438ec9356a6a55a4ed3bb22cf80b9ab554a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369075 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#806893} -- wpt-commits: d77aecb43a161cdf3b62cc8a35473e00f96d3238 wpt-pr: 25178
sidvishnoi
pushed a commit
to sidvishnoi/gecko-webmonetization
that referenced
this pull request
Sep 24, 2020
…ts for classic scripts and SharedWorkers, a=testonly Automatic update from web-platform-tests [WPT] Add microtask-related ordering tests for classic scripts and SharedWorkers Classic script and SharedWorker versions of https://chromium-review.googlesource.com/c/chromium/src/+/2346251 web-platform-tests/wpt#24948 Bug: 1114028, 1128214 Change-Id: I44353438ec9356a6a55a4ed3bb22cf80b9ab554a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369075 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#806893} -- wpt-commits: d77aecb43a161cdf3b62cc8a35473e00f96d3238 wpt-pr: 25178
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Sep 28, 2020
…ts for classic scripts and SharedWorkers, a=testonly Automatic update from web-platform-tests [WPT] Add microtask-related ordering tests for classic scripts and SharedWorkers Classic script and SharedWorker versions of https://chromium-review.googlesource.com/c/chromium/src/+/2346251 web-platform-tests/wpt#24948 Bug: 1114028, 1128214 Change-Id: I44353438ec9356a6a55a4ed3bb22cf80b9ab554a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369075 Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org> Reviewed-by: Dominic Farolino <domchromium.org> Cr-Commit-Position: refs/heads/master{#806893} -- wpt-commits: d77aecb43a161cdf3b62cc8a35473e00f96d3238 wpt-pr: 25178 UltraBlame original commit: 65213faff9f8f352e265a862f1a3f1639a6e84c6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 28, 2020
…ts for classic scripts and SharedWorkers, a=testonly Automatic update from web-platform-tests [WPT] Add microtask-related ordering tests for classic scripts and SharedWorkers Classic script and SharedWorker versions of https://chromium-review.googlesource.com/c/chromium/src/+/2346251 web-platform-tests/wpt#24948 Bug: 1114028, 1128214 Change-Id: I44353438ec9356a6a55a4ed3bb22cf80b9ab554a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369075 Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org> Reviewed-by: Dominic Farolino <domchromium.org> Cr-Commit-Position: refs/heads/master{#806893} -- wpt-commits: d77aecb43a161cdf3b62cc8a35473e00f96d3238 wpt-pr: 25178 UltraBlame original commit: 65213faff9f8f352e265a862f1a3f1639a6e84c6
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Sep 28, 2020
…ts for classic scripts and SharedWorkers, a=testonly Automatic update from web-platform-tests [WPT] Add microtask-related ordering tests for classic scripts and SharedWorkers Classic script and SharedWorker versions of https://chromium-review.googlesource.com/c/chromium/src/+/2346251 web-platform-tests/wpt#24948 Bug: 1114028, 1128214 Change-Id: I44353438ec9356a6a55a4ed3bb22cf80b9ab554a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369075 Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org> Reviewed-by: Dominic Farolino <domchromium.org> Cr-Commit-Position: refs/heads/master{#806893} -- wpt-commits: d77aecb43a161cdf3b62cc8a35473e00f96d3238 wpt-pr: 25178 UltraBlame original commit: 65213faff9f8f352e265a862f1a3f1639a6e84c6
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
…aredWorkers Classic script and SharedWorker versions of https://chromium-review.googlesource.com/c/chromium/src/+/2346251 web-platform-tests/wpt#24948 Bug: 1114028, 1128214 Change-Id: I44353438ec9356a6a55a4ed3bb22cf80b9ab554a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369075 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#806893} GitOrigin-RevId: 5c29c109b511d7bb0864c0b099dc4239125d8403
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for upcoming microtask checkpoint fixes and top-level-await
for modules. The added test cover in more detail the following items:
drive-by-fix: Check for onunhandledrejection
Bug: 1022182, 1096455, 1114034, v8:9344
Change-Id: Ieaa7691bf44e2758ed873ca53bcc6852812dd723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346251
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798126}