[Gecko Bug 1414600] Make media queries and viewport units in print be evaluated against the default page size minus margins. #25087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he default page size minus margins. For that, move the default page margin computation to nsPresContext. See w3c/csswg-drafts#5437 as to why doing this and other alternatives. Differential Revision: https://phabricator.services.mozilla.com/D87311 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1414600 gecko-commit: b6d1532f6cd4f3dabe20557fddcfb8595a6ba809 gecko-integration-branch: autoland gecko-reviewers: dholbert, nordzilla
wpt-pr-bot
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For that, move the default page margin computation to nsPresContext.
See w3c/csswg-drafts#5437 as to why doing this
and other alternatives.
Differential Revision: https://phabricator.services.mozilla.com/D87311
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1414600
gecko-commit: b6d1532f6cd4f3dabe20557fddcfb8595a6ba809
gecko-integration-branch: autoland
gecko-reviewers: dholbert, nordzilla