Revert "Give blink::CueTimeline a timer for precisely handling cue events" #25170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents" This reverts commit cb9cdc6693ba2ac64292494cca7ad28a6a00f084. Reason for revert: This CL is likely the cause of build failure for Builder Linux Tests (dbg)(1) since https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/91043. Revert to see if that fix the build Original change's description: > Give blink::CueTimeline a timer for precisely handling cue events > > Cue-related events (enter, exit, cuechange) are fired up to 250ms late, > and there is a similar latency in their display which is quite > noticeable. > > The underlying problem is that we only update cues alongside the > `timeupdate` event, which is fixed at 4 Hz. > > My solution is to add a separate timer to CueTimeline > (`CueTimeline::cue_event_timer_`) which is given a timeout for the > next cue event based on the current playback position and rate. This > allows for significantly more precise cue timing accuracy without a > significant performance penalty. > > Additionally, several web tests were written with the expectation that > the 'time marches on' algorithm is run before video playback begins > (ie, upon loading text track cues). This behavior is not in accordance > with the spec (as outlined in crbug/1050767), so this CL fixes those > expectations and adds a new test to prevent regressing. > > Bug: 576310, 1050767 > Change-Id: I675f5f030a68ba9cee10e12b3e79a9b174048193 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008079 > Commit-Queue: Will Cassella <cassew@google.com> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#800148} TBR=fs@opera.com,alancutter@chromium.org,mlamouri@chromium.org,cassew@google.com Change-Id: I0563b173344cef976c16b4f2851b45762a67843f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 576310 Bug: 1050767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368614 Reviewed-by: Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#800432}
wpt-pr-bot
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cb9cdc6693ba2ac64292494cca7ad28a6a00f084.
Reason for revert: This CL is likely the cause of build failure for Builder Linux Tests (dbg)(1) since https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/91043. Revert to see if that fix the build
Original change's description:
TBR=fs@opera.com,alancutter@chromium.org,mlamouri@chromium.org,cassew@google.com
Change-Id: I0563b173344cef976c16b4f2851b45762a67843f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 576310
Bug: 1050767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368614
Reviewed-by: Maggie Cai <mxcai@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800432}