Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Fix ScrollableOverflowForPropagation() #25593

Merged
merged 1 commit into from Sep 18, 2020

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Sep 17, 2020

NGPhysicalFragment::ScrollableOverflowForPropagation()
had an important different compared
to LayoutBox::LayoutOverflowRectForPropagation()
as it was not including the border box when computing
the overflow for propagation.

This was causing issues in some cases calculating the overflow
of replaced elements in LayoutNG, legacy was working fine.

This patch changes AdjustScrollableOverflowForPropagation()
to also include the element's border box.

Note that we cannot do this for ruby boxes
as they have some special behavior
(see crbug.com/1082087 and r784709 for details).

We need new rebaselines for the following test
fast/replaced/border-radius-clip.html
This is because when you scroll down you can see
the border of the embed object (which was hidden before).

BUG=1128984
TEST=css/css-overflow/overflow-replaced-element-001.html

Change-Id: I038ccb46db7e00a922e33a387cf10e3c805b81c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414313
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#808518}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2414313 branch 2 times, most recently from 1a279ea to 7b93848 Sep 18, 2020
NGPhysicalFragment::ScrollableOverflowForPropagation()
had an important different compared
to LayoutBox::LayoutOverflowRectForPropagation()
as it was not including the border box when computing
the overflow for propagation.

This was causing issues in some cases calculating the overflow
of replaced elements in LayoutNG, legacy was working fine.

This patch changes AdjustScrollableOverflowForPropagation()
to also include the element's border box.

Note that we cannot do this for ruby boxes
as they have some special behavior
(see crbug.com/1082087 and r784709 for details).

We need new rebaselines for the following test
fast/replaced/border-radius-clip.html
This is because when you scroll down you can see
the border of the embed object (which was hidden before).

BUG=1128984
TEST=css/css-overflow/overflow-replaced-element-001.html

Change-Id: I038ccb46db7e00a922e33a387cf10e3c805b81c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414313
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#808518}
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2414313 branch from 7b93848 to f05860a Sep 18, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 73cc37d into master Sep 18, 2020
19 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-2414313 branch Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants