Initial support for worker memory in performance.measureMemory() #25672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 22, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2421707
branch
2 times, most recently
from
f833cbf
to
777fa2b
Compare
The result of performance.measureMemory() now includes the memory
usage of dedicated workers running in the same site-isolated
renderer process. Example entry of the result:
{
bytes: 1000000,
attribution: [],
userAgentSpecificTypes: ["DedicatedWorkerGlobalScope","JS"]
}
The worker URLs are not available in this implementation because
it does not go through PerformanceManager in the browser process.
Instead, it directly queries V8WorkerMemoryReporter implemented in
renderer/controller/performance_manager.
Since renderer/core cannot depend on renderer/controller,
V8WorkerMemoryReporter is injected during initialization.
The upcoming mojo-based implementation will add URLs.
Bug: 1085129
Change-Id: I53f34c1136192c9156e2bb74e41327b5a60e0f66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421707
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810566}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2421707
branch
from
777fa2b
to
dcab900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of performance.measureMemory() now includes the memory
usage of dedicated workers running in the same site-isolated
renderer process. Example entry of the result:
{
bytes: 1000000,
attribution: [],
userAgentSpecificTypes: ["DedicatedWorkerGlobalScope","JS"]
}
The worker URLs are not available in this implementation because
it does not go through PerformanceManager in the browser process.
Instead, it directly queries V8WorkerMemoryReporter implemented in
renderer/controller/performance_manager.
Since renderer/core cannot depend on renderer/controller,
V8WorkerMemoryReporter is injected during initialization.
The upcoming mojo-based implementation will add URLs.
Bug: 1085129
Change-Id: I53f34c1136192c9156e2bb74e41327b5a60e0f66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421707
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810566}