Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[url] Add a few url tests to cover cases that were not tested before. #25987

Merged
merged 1 commit into from
Oct 5, 2020
Merged

[url] Add a few url tests to cover cases that were not tested before. #25987

merged 1 commit into from
Oct 5, 2020

Commits on Oct 5, 2020

  1. [url] Add a few url tests to cover cases that were not tested before. 

    The first tests around edge cases of the U_IS_UNICODE_CHAR macro,
which my younger and more naive self used until http://trac.webkit.org/r267963
and Chrome seems to do something similar.

The second and third test what happens when parsing terminates in the file slash
state with relative file URLs with and without windows drive letters, which
terminal state I forgot in my initial implementation of file host copying in
http://trac.webkit.org/r267896

The last verifies that using a windows drive letter as a relative file URL path
removes all of the base URL's path including any drive letter it may have.
This is something I was unsure about when implementing r267964 but matches the
behavior of IE and Edge.
    @achristensen07
    achristensen07 committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    54471b0 View commit details
    Browse the repository at this point in the history