Migrate credential-management WPTs to JS modules #26120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 14, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2472201
branch
4 times, most recently
from
da9b063
to
14d025a
Compare
Update the credential-management WPTs to use JS modules, including for Mojo JS bindings. This also refactors the supporting modules to isolate individual tests from any browser-specific details. Bug: 1004256 Change-Id: If5428dbd4f371fdc92c62da2a2378e8221c5c658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472201 Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#817715}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2472201
branch
from
14d025a
to
56cd8a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the credential-management WPTs to use JS modules, including for
Mojo JS bindings.
This also refactors the supporting modules to isolate individual
tests from any browser-specific details.
Bug: 1004256
Change-Id: If5428dbd4f371fdc92c62da2a2378e8221c5c658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472201
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#817715}