Add StreamPipeOptions to Readable Streams #26251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 23, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2488329
branch
2 times, most recently
from
60fda82
to
c1bc18c
Compare
In an effort to change the blink implementation of readable streams to better match the Web IDL descriptions in the Streams API Standard, this CL adds the StreamPipeOptions dictionary [1] to the ReadableStream class. [1] https://streams.spec.whatwg.org/#dictdef-streampipeoptions Bug: 1093862 Change-Id: Ic03fff0d645786dd48c4d8b7cd8682e0442bff0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488329 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#821113}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2488329
branch
from
c1bc18c
to
42228d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to change the blink implementation of readable
streams to better match the Web IDL descriptions in the Streams
API Standard, this CL adds the StreamPipeOptions dictionary [1]
to the ReadableStream class.
[1] https://streams.spec.whatwg.org/#dictdef-streampipeoptions
Bug: 1093862
Change-Id: Ic03fff0d645786dd48c4d8b7cd8682e0442bff0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488329
Commit-Queue: Nidhi Jaju <nidhijaju@google.com>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821113}