Map the aspect ratio from width/height to CSS #26261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 23, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2495560
branch
3 times, most recently
from
5222e4d
to
e5beaa9
Compare
Instead of having special code in image layout, map the aspect ratio that's computed from the width and height attributes to the aspect-ratio property. As a side-effect, this patch will also make the aspect-ratio property work when contain: size is specified in an image (as well as error images when no alt text is specified). As specified in whatwg/html#6032. R=masonfreed@chromium.org, xiaochengh@chromium.org Bug: 1137004 Change-Id: I1253fa2ecf1e176711d3c4d7bd4159f466656ae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495560 Reviewed-by: Yu Han <yuzhehan@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#823124}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2495560
branch
from
e5beaa9
to
6391955
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having special code in image layout, map the aspect ratio that's
computed from the width and height attributes to the aspect-ratio property.
As a side-effect, this patch will also make the aspect-ratio property work
when contain: size is specified in an image (as well as error images when
no alt text is specified).
As specified in whatwg/html#6032.
R=masonfreed@chromium.org, xiaochengh@chromium.org
Bug: 1137004
Change-Id: I1253fa2ecf1e176711d3c4d7bd4159f466656ae8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495560
Reviewed-by: Yu Han <yuzhehan@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823124}