[client-hints] Viewport-Width correct value for navigation requests #26334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 29, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2494876
branch
3 times, most recently
from
9aff980
to
595f9e5
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2494876
branch
3 times, most recently
from
6f15a24
to
affa7bb
Compare
Currently, Viewport-Width hints send the display width for navigation requests, rather than the actual viewport width. This CL fixes that for iframes and for new windows that have the same viewport as their opener. Bug: 825892 Change-Id: Ib01f394325ed3753b9a89dbdbcada1db0d3b029c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494876 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#826750}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2494876
branch
from
affa7bb
to
6561e4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Viewport-Width hints send the display width for navigation
requests, rather than the actual viewport width.
This CL fixes that for iframes and for new windows that have the same
viewport as their opener.
Bug: 825892
Change-Id: Ib01f394325ed3753b9a89dbdbcada1db0d3b029c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494876
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826750}