BFCache: Make a WPT test work with BFCache #26408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 5, 2020
If we enable same-site backward/forward cache, backward navigation does not trigger onload event. This CL updates a WPT that depends on the onload event to handle pageshow event and makes it work with backward/forward cache. Bug: 1132180 Change-Id: I663f9c78e8b9835f081c5262b446bd56dba07cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520558 Reviewed-by: Fergal Daly <fergal@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#824321}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2520558
branch
from
dd7ffd7
to
73de7cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we enable same-site backward/forward cache, backward navigation
does not trigger onload event.
This CL updates a WPT that depends on the onload event to handle
pageshow event and makes it work with backward/forward cache.
Bug: 1132180
Change-Id: I663f9c78e8b9835f081c5262b446bd56dba07cf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520558
Reviewed-by: Fergal Daly <fergal@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824321}