Don't crash on SVG-as-canvas drawImage #26424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 5, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2521049
branch
2 times, most recently
from
5de6db3
to
2a6f0c9
Compare
The check for same-origin for image files with EXIF in canvas drawImage was crashing for SVG images because their security origin status is not available until the image has loaded. Change things to not check SVG images for canvas drawImage, which is safe because the image will be checked when drawing the SVG itself. Add a test for various uses of images in SVG. Bug: 1141412 Change-Id: I4bd39b6d10afec4c4134b24609aa02c53359361b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521049 Reviewed-by: Yi Xu <yiyix@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#825112}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2521049
branch
from
2a6f0c9
to
0f25582
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for same-origin for image files with EXIF in canvas
drawImage was crashing for SVG images because their security
origin status is not available until the image has loaded.
Change things to not check SVG images for canvas drawImage,
which is safe because the image will be checked when drawing
the SVG itself.
Add a test for various uses of images in SVG.
Bug: 1141412
Change-Id: I4bd39b6d10afec4c4134b24609aa02c53359361b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521049
Reviewed-by: Yi Xu <yiyix@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825112}