Improve will-change:transform raster scale adjustment #26475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 10, 2020
This fixes the issue of too big scale for will-change:transform layers by - Partly reverting crrev.com/c/2447650 to apply the change on tiny scales only. When the ideal scale is not tiny, use the original policy to clamp minimum scale to the native scale. - Increasing kMinScaleRatioForWillChangeTransform from 0.1 to 0.25 to reduce memory and number of tiles when the scale is bigger than ideal, from 100x to 16x in worst cases. Bug: 1146393 Change-Id: Ida5720f5126648c2fad0b9921781714fa006d346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527733 Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825998}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2527733
branch
from
0f61bd2
to
dc3b25a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of too big scale for will-change:transform layers
by
scales only. When the ideal scale is not tiny, use the original policy
to clamp minimum scale to the native scale.
reduce memory and number of tiles when the scale is bigger than ideal,
from 100x to 16x in worst cases.
Bug: 1146393
Change-Id: Ida5720f5126648c2fad0b9921781714fa006d346
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527733
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825998}