[PeerConnection] Improve getStats WPT test coverage. #26504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 12, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2534911
branch
3 times, most recently
from
5d5b433
to
557952e
Compare
This CL adds two tests that were discovered missing while reviewing the test coverage, both of which we PASS: - getStats(tracks) throws if multiple senders have the same track. (Actually it turns out such a test already existed, the old one is removed because it was asserting unnecessarily many things.) - RTCStats.timestamp should increase with time elapsed. This CL also makes exsting tests more behavior driven. For example, a test that advertises itself to test that "report containing peer-connection stats and outbound-track-stats" should not fail because we have not implemented RTCCodecStats.sdpFmtpLine - this is a different behavior. As such, tests that are designed to test the existence of a stats object are updated only to verify that. What the old tests were verifying - that the ENTIRE REPORT is valid and complete - are moved and tested in a separate test that asserts everything. These tests we still fail because of sdpFmtpLine. Lastly, the outbound-rtp tests are updated to perform an O/A exchange. If the senders have not been negotiated to send, there doesn't exist an encoder or RTP packetizer and as such we shouldn't expect to see outbound-rtp objects yet. Bug: chromium:1148286 Change-Id: I50d476f1af41cfae80c77486481e3de06a1d8f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534911 Reviewed-by: Philipp Hancke <philipp.hancke@googlemail.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#827758}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2534911
branch
from
557952e
to
e4f9d65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds two tests that were discovered missing while reviewing the
test coverage, both of which we PASS:
(Actually it turns out such a test already existed, the old one is
removed because it was asserting unnecessarily many things.)
This CL also makes exsting tests more behavior driven. For example, a
test that advertises itself to test that "report containing
peer-connection stats and outbound-track-stats" should not fail because
we have not implemented RTCCodecStats.sdpFmtpLine - this is a different
behavior. As such, tests that are designed to test the existence of a
stats object are updated only to verify that.
What the old tests were verifying - that the ENTIRE REPORT is valid
and complete - are moved and tested in a separate test that asserts
everything. These tests we still fail because of sdpFmtpLine.
Lastly, the outbound-rtp tests are updated to perform an O/A exchange.
If the senders have not been negotiated to send, there doesn't exist
an encoder or RTP packetizer and as such we shouldn't expect to see
outbound-rtp objects yet.
Bug: chromium:1148286
Change-Id: I50d476f1af41cfae80c77486481e3de06a1d8f5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534911
Reviewed-by: Philipp Hancke <philipp.hancke@googlemail.com>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827758}