Test handover - reconnect a PeerConnection to another remote #26520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 13, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2537630
branch
from
0b05913
to
bdaade4
Compare
This functionality is being used, but wasn't tested. This is a skeleton test - just checks that the negotiation steps succeed. Bug: none Change-Id: Ic1b6fa2df77730d42b44f122ed5b29f147505077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537630 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#827225}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2537630
branch
from
bdaade4
to
bb5d2a2
Compare
|
This test is not valid, because to the offerer this looks like the remote end is trying to cause an ICE restart in its answer. This is not legal SDP negotiation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is being used, but wasn't tested.
This is a skeleton test - just checks that the negotiation
steps succeed.
Bug: none
Change-Id: Ic1b6fa2df77730d42b44f122ed5b29f147505077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537630
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827225}