content-visibility: Ensure to propagate positioned movement layout dirty bit. #26543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 16, 2020
…rty bit. This patch ensures that we propagate the positioned movement layout dirty bit since it affects "self layout" in the sense that it is the object itself that could be positioned differently, not necessarily its child. The early out right now protects us from propagating child only dirty bits, since those updates would be blocked anyway. R=ikilpatrick@chromium.org, chrishtr@chromium.org Change-Id: I1ed4850317ff0248fc74a9ad09fedba2d5fa2041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542305 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#828928}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2542305
branch
from
66a2f7e
to
d3c443b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that we propagate the positioned movement layout dirty
bit since it affects "self layout" in the sense that it is the object
itself that could be positioned differently, not necessarily its child.
The early out right now protects us from propagating child only dirty
bits, since those updates would be blocked anyway.
R=ikilpatrick@chromium.org, chrishtr@chromium.org
Change-Id: I1ed4850317ff0248fc74a9ad09fedba2d5fa2041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542305
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828928}