Add test to check scrollable overflow of abspos elements #26657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javifernandez
approved these changes
Nov 27, 2020
Loirooriol
approved these changes
Nov 27, 2020
| <div class="abspos" style="height: 500px; left: -50px;"></div> | ||
| </div> | ||
| <div class="containing-block" data-expected-scroll-width="100" data-expected-scroll-height="550"> | ||
| <div class="abspos" style="height: 500px; left: -50px; top: 50px;"></div> |
There was a problem hiding this comment.
Nit: the order in height: 500px; left: -50px; top: 50px; makes it harder to see what's happening since the horizontal left: -50px is placed between the vertical declarations. IMO would be clearer as height: 500px; top: 50px; left: -50px;. Ditto for the following cases.
There was a problem hiding this comment.
Sorry, I had already merged it. I've fixed that in ##26659.
mrego
added a commit
to mrego/wpt
that referenced
this pull request
Nov 27, 2020
Apply suggestion from review after the test has landed: web-platform-tests#26657 (review)
mrego
added a commit
that referenced
this pull request
Nov 27, 2020
Apply suggestion from review after the test has landed: #26657 (review)
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 4, 2020
…-001.html, a=testonly Automatic update from web-platform-tests Fix positon-absolute-scrollable-overflow-001.html Apply suggestion from review after the test has landed: web-platform-tests/wpt#26657 (review) -- Address review comment -- wpt-commits: a032b341c4dcd16ca4551da719a8c83a2e55d910, 819004e487f30f8f88c71f37c7d9f80f2aed0064 wpt-pr: 26659
sidvishnoi
pushed a commit
to sidvishnoi/gecko-webmonetization
that referenced
this pull request
Dec 10, 2020
…-001.html, a=testonly Automatic update from web-platform-tests Fix positon-absolute-scrollable-overflow-001.html Apply suggestion from review after the test has landed: web-platform-tests/wpt#26657 (review) -- Address review comment -- wpt-commits: a032b341c4dcd16ca4551da719a8c83a2e55d910, 819004e487f30f8f88c71f37c7d9f80f2aed0064 wpt-pr: 26659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.