[Gecko Bug 1679461] Use SetSelectionRange in Select(), regardless of focus state #26718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SelectAll() also is no-op without a frame, so this replaces it with SetSelectionRange. Differential Revision: https://phabricator.services.mozilla.com/D98184 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1679461 gecko-commit: 4f4fd8e7ce937abcd8ba7c4fc85bd9d4b352d9f3 gecko-reviewers: masayuki
wpt-pr-bot
approved these changes
Dec 2, 2020
…est_focus.xhtml failures CLOSED TREE Backed out changeset 03db12dabc63 (bug 1677263) Backed out changeset 75de13448090 (bug 1679460) Backed out changeset 4f4fd8e7ce93 (bug 1679461) gecko-commit: 12f831d0496c549f9b90146e3e941d0c9e154b25
SelectAll() also is no-op without a frame, so this replaces it with SetSelectionRange. Differential Revision: https://phabricator.services.mozilla.com/D98184 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1679461 gecko-commit: 510a46e365e0ba8154f1f105c6d3aa8f922c2339 gecko-reviewers: masayuki
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SelectAll() also is no-op without a frame, so this replaces it with SetSelectionRange.
Differential Revision: https://phabricator.services.mozilla.com/D98184
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1679461
gecko-commit: 4f4fd8e7ce937abcd8ba7c4fc85bd9d4b352d9f3
gecko-reviewers: masayuki