Add WPT that checks autoAllocateChunkSize cannot be 0 #26735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 3, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2569490
branch
2 times, most recently
from
bb29dba
to
0cc045e
Compare
This CL adds a new WPT for the case that a ReadableStream with a byte source, and hence a ReadableByteStreamController is constructed, with autoAllocateChunkSize: 0. This should throw a Type Error because autoAllocateChunkSize cannot be 0, and should rather be positive. Bug: 614302 Change-Id: Iea15e4730f4965d52ff5c68367ba6212d5eca089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569490 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#834112}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2569490
branch
from
0cc045e
to
bdb1983
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds a new WPT for the case that a ReadableStream with a byte
source, and hence a ReadableByteStreamController is constructed, with
autoAllocateChunkSize: 0. This should throw a Type Error because
autoAllocateChunkSize cannot be 0, and should rather be positive.
Bug: 614302
Change-Id: Iea15e4730f4965d52ff5c68367ba6212d5eca089
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569490
Commit-Queue: Nidhi Jaju <nidhijaju@google.com>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834112}