[Import Maps] Add tests for non-ASCII characters #26753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 4, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2573422
branch
from
4723e12
to
3bd43fe
Compare
As the non-bare keys and resolution results of specifier maps are normalized (i.e. serialized URLs), raw and percent-encoded non-ASCII strings are considered equal (as both of them are percent-encoded after serialization). This CL tests that raw and percent-encoded versions of non-ASCII characters are: - Considered equal in non-bare specifier keys, - Considered equal in checking backtracking, and - Not considered equal in bare specifier keys. For consistency, this CL also adds some backtracking tests that don't involve non-ASCII characters but use the same patterns of added non-ASCII tests. Bug: 848607, WICG/import-maps#207 Change-Id: I6c8ae478da2fcbe0f6df03a608dabdad60644ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573422 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#835824}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2573422
branch
from
3bd43fe
to
a1bcaed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the non-bare keys and resolution results of
specifier maps are normalized (i.e. serialized URLs),
raw and percent-encoded non-ASCII strings are
considered equal (as both of them are
percent-encoded after serialization).
This CL tests that raw and percent-encoded versions of
non-ASCII characters are:
For consistency, this CL also adds some backtracking tests
that don't involve non-ASCII characters but use
the same patterns of added non-ASCII tests.
Bug: 848607, WICG/import-maps#207
Change-Id: I6c8ae478da2fcbe0f6df03a608dabdad60644ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573422
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835824}