Fix sandbox flags inheritance with javascript-url. #26801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 8, 2020
From the browser process point of view: - javascript-url document. - XSLT document. - document.open document. Are all a no-op. (e.g. no IPC sent to the browser process). The security properties of the document shouldn't change. There was a bug about sandbox_flags inheritance and javascript-url. We weren't inheriting from the right flags. Bug: 1151954 Change-Id: I7dc3cdfff4eaa8d0db02a2aaab6963a6aa3c8ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577211 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835212}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2577211
branch
from
c32a024
to
7dcd579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the browser process point of view:
Are all a no-op. (e.g. no IPC sent to the browser process). The security
properties of the document shouldn't change.
There was a bug about sandbox_flags inheritance and javascript-url. We
weren't inheriting from the right flags.
Bug: 1151954
Change-Id: I7dc3cdfff4eaa8d0db02a2aaab6963a6aa3c8ef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577211
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835212}