StorageBuckets: Initial browser implementation #26846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 10, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2368412
branch
3 times, most recently
from
64530c5
to
e595761
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2368412
branch
2 times, most recently
from
cfb83f1
to
bf821da
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2368412
branch
from
bf821da
to
f71dce5
Compare
This change adds the mojo equivalent of the StorageBuckets API, and the interface between StoragePartitionImpl and Buckets. This does not have the full implementation of the API and only stores bucket names in the browser process. The implementation will come in following CLs. Tested by wpt: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/external/wpt/storage/buckets/buckets_basic.tentative.https.any.js?q=f:storage%2Fbuckets%20f:wpt&ss=chromium API explainer: https://github.com/WICG/storage-buckets/blob/gh-pages/explainer.md Binary-Size: New Web Platform feature P1. Bug: 1107946 Change-Id: I0b5bb16b821962aace392cb1c130d28eaf0753e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368412 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#849776}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2368412
branch
from
f71dce5
to
ec204a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the mojo equivalent of the
StorageBuckets API, and the interface between
StoragePartitionImpl and Buckets. This does not
have the full implementation of the API and only
stores bucket names in the browser process.
The implementation will come in following CLs.
Tested by wpt: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/external/wpt/storage/buckets/buckets_basic.tentative.https.any.js?q=f:storage%2Fbuckets%20f:wpt&ss=chromium
API explainer: https://github.com/WICG/storage-buckets/blob/gh-pages/explainer.md
Binary-Size: New Web Platform feature P1.
Bug: 1107946
Change-Id: I0b5bb16b821962aace392cb1c130d28eaf0753e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368412
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#849776}