[UA-CH] Rename Accept-CH tokens #26945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 17, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2595089
branch
from
520e870
to
869f0c0
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2595089
branch
from
869f0c0
to
724927b
Compare
Bring tokens inline with Section 3.1 of the Client Hints spec, which recommends tokens be the same as the header name they're associated with. Also fixing the *copious* tests associated with this change... Intent to Remove: https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/t-S9nnos9qU Bug: 1153688 Change-Id: I2bfe038abe887713d56ef835e8f9d61246001040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595089 Reviewed-by: Maksim Orlovich <morlovich@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#846075}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2595089
branch
from
724927b
to
b8f8af1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring tokens inline with Section 3.1 of the Client Hints spec, which
recommends tokens be the same as the header name they're associated
with.
Also fixing the copious tests associated with this change...
Intent to Remove: https://groups.google.com/u/1/a/chromium.org/g/blink-dev/c/t-S9nnos9qU
Bug: 1153688
Change-Id: I2bfe038abe887713d56ef835e8f9d61246001040
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595089
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846075}