Do not use plugin-types for trusted-types WPTs #27305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 25, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2646825
branch
from
9d91438
to
65a19fd
Compare
Some web platform tests for trusted types trigger a violation of the CSP directive plugin-types to verify that a CSP violation trigger. The plugin-types directive is specified with an invalid (hence in practice empty) value. With the removal of the 'plugin-types' directive implementations, these tests will break. This CL converts those tests to trigger violations of the 'object-src' directive instead. Bug: 1168001 Change-Id: I042a7c600bc5c7caeb6dd87ff94b181b5fb66b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2646825 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#847151}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2646825
branch
from
65a19fd
to
5f1d829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some web platform tests for trusted types trigger a violation of the
CSP directive plugin-types to verify that a CSP violation trigger. The
plugin-types directive is specified with an invalid (hence in practice
empty) value. With the removal of the 'plugin-types' directive
implementations, these tests will break.
This CL converts those tests to trigger violations of the 'object-src'
directive instead.
Bug: 1168001
Change-Id: I042a7c600bc5c7caeb6dd87ff94b181b5fb66b6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2646825
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#847151}